Jaeger Propagator: Fix accepting short trace and span IDs #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrister
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
reviewed
Sep 5, 2022
|
@mfrister Could you please sign the CLA? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
=======================================
- Coverage 69.4% 69.3% -0.1%
=======================================
Files 145 145
Lines 6707 6712 +5
=======================================
+ Hits 4655 4657 +2
- Misses 1938 1940 +2
- Partials 114 115 +1
|
Sure, I'm already working on it. Will need a corporate CLA, so this might take a few days. |
mfrister
force-pushed
the
fix-jaeger-propagator-short-ids
branch
from
aef1eb8
to
5d93e04
Compare
Aneurysm9
added
bug
mfrister
force-pushed
the
fix-jaeger-propagator-short-ids
branch
from
5d93e04
to
e8f2b23
Compare
|
@Aneurysm9 I've got the CLA signed and I've added a changelog entry. |
Aneurysm9
removed
the
blocked: CLA
Aneurysm9
approved these changes
Sep 8, 2022
dmathieu
approved these changes
Sep 8, 2022
mfrister
force-pushed
the
fix-jaeger-propagator-short-ids
branch
from
e8f2b23
to
6e03784
Compare
MrAlias
approved these changes
Sep 8, 2022
mfrister
force-pushed
the
fix-jaeger-propagator-short-ids
branch
from
6e03784
to
339643c
Compare
The Jaeger propagation format spec [1] requires servers to 0-left-pad hex string values shorter than 32 bytes. The Jaeger Python client library generates variable-length hex strings from Trace IDs, with leading zeroes being omitted, so this fixes an interoperability issue. [1] https://www.jaegertracing.io/docs/1.37/client-libraries/#value
The Jaeger propagation format spec says servers must 0-left-pad span IDs shorter than 64 bit, just like they do with trace IDs. fixup span
mfrister
force-pushed
the
fix-jaeger-propagator-short-ids
branch
from
339643c
to
b4a5d2c
Compare
hanyuancheung
approved these changes
Sep 14, 2022
|
Is there anything missing for this to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2729.
While implementing the fix for trace IDs, i noticed that span IDs have the same requirement, so I fixed them as well.
As an optimization, we could keep the special case for 64-bit tracing IDs with a constant padding. I'm not sure it's worth it, so I haven't implemented this for now.