Add TextMapPropagator function to autoprop #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the parseEnv function logic that already performed this function into GetTextMapPropagator, and use that in parseEnv instead.
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2593 +/- ##
=====================================
Coverage 74.3% 74.3%
=====================================
Files 144 144
Lines 6569 6569
=====================================
Hits 4883 4883
Misses 1543 1543
Partials 143 143
|
Aneurysm9
approved these changes
Jul 22, 2022
dashpole
approved these changes
Jul 22, 2022
pellared
reviewed
Jul 25, 2022
pellared
approved these changes
Jul 25, 2022
MrAlias
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2590
The collector plans to add configuration that will use a propagator describe in a text configuration file. That text needs to be converted into a propagator. This adds the
GetTextMapPropagatorfunction to do that conversion.