Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP instrumentations to set proper span status #2427

Merged
merged 1 commit into from Jun 24, 2022
Merged

Fix HTTP instrumentations to set proper span status #2427

merged 1 commit into from Jun 24, 2022

Conversation

pellared
Copy link
Member

Fix the otelhttp, otelgin, otelmacaron, otelrestful middlewares
by using SpanKindServer when deciding the SpanStatus.
This makes 4xx response codes not to be an error anymore.

Similar PRs #1848, #1973

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #2427 (8b14968) into main (f2c368a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head 8b14968 differs from pull request most recent head 2679054. Consider uploading reports for the commit 2679054 to get more accurate results

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2427   +/-   ##
=====================================
  Coverage   74.2%   74.3%           
=====================================
  Files        144     144           
  Lines       6563    6563           
=====================================
+ Hits        4874    4877    +3     
+ Misses      1546    1543    -3     
  Partials     143     143           
Impacted Files Coverage Δ
...hub.com/emicklei/go-restful/otelrestful/restful.go 100.0% <100.0%> (ø)
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 80.7% <100.0%> (ø)
...ntation/gopkg.in/macaron.v1/otelmacaron/macaron.go 91.8% <100.0%> (ø)
instrumentation/net/http/otelhttp/handler.go 81.0% <100.0%> (+1.8%) ⬆️

@MrAlias MrAlias merged commit 18e11ae into open-telemetry:main Jun 24, 2022
@pellared pellared deleted the fix-http-server-statuses branch June 25, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants