Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return metric SDK testing using metrictest #2224

Merged
merged 5 commits into from Apr 27, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 26, 2022

@MrAlias MrAlias added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Apr 26, 2022
Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2224 (acc0502) into main (8b86920) will increase coverage by 6.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2224     +/-   ##
=======================================
+ Coverage   70.7%   77.0%   +6.2%     
=======================================
  Files        139     141      +2     
  Lines       6386    6432     +46     
=======================================
+ Hits        4517    4953    +436     
+ Misses      1741    1324    -417     
- Partials     128     155     +27     
Impacted Files Coverage Δ
.../github.com/gocql/gocql/otelgocql/internal/cass.go 95.1% <0.0%> (ø)
...n/github.com/gocql/gocql/otelgocql/test/version.go 0.0% <0.0%> (ø)
instrumentation/runtime/runtime.go 74.0% <0.0%> (+20.2%) ⬆️
...ion/github.com/gocql/gocql/otelgocql/instrument.go 62.5% <0.0%> (+62.5%) ⬆️
...ntation/github.com/gocql/gocql/otelgocql/config.go 67.3% <0.0%> (+67.3%) ⬆️
instrumentation/host/host.go 74.4% <0.0%> (+74.4%) ⬆️
...ation/github.com/gocql/gocql/otelgocql/observer.go 75.1% <0.0%> (+75.1%) ⬆️
instrumentation/host/version.go 100.0% <0.0%> (+100.0%) ⬆️
...entation/github.com/gocql/gocql/otelgocql/gocql.go 100.0% <0.0%> (+100.0%) ⬆️
...tation/github.com/gocql/gocql/otelgocql/version.go 100.0% <0.0%> (+100.0%) ⬆️

@MrAlias MrAlias merged commit 93b5a37 into open-telemetry:main Apr 27, 2022
@MrAlias MrAlias deleted the revert-metrictest-rm branch April 27, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants