Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade semconv to v1.10.0 #2222

Merged
merged 7 commits into from Apr 28, 2022
Merged

Upgrade semconv to v1.10.0 #2222

merged 7 commits into from Apr 28, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 25, 2022 •
edited

@MrAlias
Upgrade semconv to v1.10.0
9acd065
@MrAlias
Update CassKeyspace func
d39dec2 
Use the DBNameKey instead of the removed DBCassandraKeyspaceKey. This
comes from
open-telemetry/opentelemetry-specification#1973
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited

Codecov Report

Merging #2222 (f051340) into main (93b5a37) will increase coverage by 5.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2222     +/-   ##
=======================================
+ Coverage   73.7%   79.3%   +5.5%     
=======================================
  Files        139     144      +5     
  Lines       6386    6451     +65     
=======================================
+ Hits        4712    5117    +405     
+ Misses      1532    1176    -356     
- Partials     142     158     +16
Impacted Files Coverage Δ
detectors/aws/ec2/ec2.go 89.0% <ø> (ø)
detectors/aws/ecs/ecs.go 54.7% <ø> (ø)
detectors/aws/eks/detector.go 35.6% <ø> (ø)
detectors/aws/lambda/detector.go 90.0% <ø> (ø)
detectors/gcp/cloud-function.go 100.0% <ø> (ø)
detectors/gcp/cloud-run.go 100.0% <ø> (ø)
detectors/gcp/gce.go 8.7% <ø> (ø)
detectors/gcp/gke.go 0.0% <ø> (ø)
...github.com/Shopify/sarama/otelsarama/dispatcher.go 100.0% <ø> (ø)
...n/github.com/Shopify/sarama/otelsarama/producer.go 94.7% <ø> (ø)
... and 32 more

@MrAlias MrAlias marked this pull request as ready for review April 26, 2022 00:25
@MrAlias MrAlias mentioned this pull request Apr 26, 2022
Closed
12 tasks
@MrAlias MrAlias closed this Apr 27, 2022
@MrAlias MrAlias reopened this Apr 27, 2022
hanyuancheung
hanyuancheung approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MrAlias MrAlias merged commit aa8e611 into open-telemetry:main Apr 28, 2022
@MrAlias MrAlias deleted the prerelease-otel-v1.7.0 branch April 28, 2022 14:54
@MrAlias MrAlias mentioned this pull request Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@pellared pellared Awaiting requested review from pellared

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrAlias @MadVikingGod @hanyuancheung