Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelhttp] Remove propagation header injection #2180

Merged
merged 4 commits into from Apr 12, 2022

Conversation

TylerHelmuth
Copy link
Member

Current otelhttp instrumentation leaks propagation headers in the response headers. This behavior is not defined so it should be removed. Fixes #2163

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2180 (8bff6f7) into main (9fafa35) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2180     +/-   ##
=======================================
- Coverage   69.4%   69.4%   -0.1%     
=======================================
  Files        135     135             
  Lines       6114    6113      -1     
=======================================
- Hits        4247    4244      -3     
- Misses      1739    1741      +2     
  Partials     128     128             
Impacted Files Coverage Δ
instrumentation/net/http/otelhttp/wrap.go 50.0% <ø> (-8.7%) ⬇️

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be mentioned in CHANGELOG.md

Copy link
Member

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
@MrAlias MrAlias merged commit 9d80058 into open-telemetry:main Apr 12, 2022
@TylerHelmuth TylerHelmuth deleted the issue-2163 branch April 12, 2022 20:47
@MrAlias MrAlias mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otelhttp.NewHandler adds backpropagation
5 participants