New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelhttp: nil check wrappedBody.Close #2164
otelhttp: nil check wrappedBody.Close #2164
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a CHANGELOG entry noting this fix? Thanks!
75693e7
to
78437aa
Compare
@Aneurysm9 added, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #2164 +/- ##
=====================================
Coverage 69.3% 69.4%
=====================================
Files 135 135
Lines 6111 6114 +3
=====================================
+ Hits 4241 4244 +3
Misses 1742 1742
Partials 128 128
|
I got a notification about an error with the GRPC instrument, but that's not part of my changes. This is what panic'd opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/test/interceptor_test.go Line 396 in f06b204
|
78437aa
to
60d9ca2
Compare
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
We're experimenting with open-telemetry and ran into a panic where
*wrappedBody.Close()
can panic. This seems to be code from 2+ years ago, so I'm surprised we ran into it.I'm happy to sign the CLA if this change will be accepted.