New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote sampling support - AWS X-Ray #1859
Remote sampling support - AWS X-Ray #1859
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1859 +/- ##
=======================================
+ Coverage 68.5% 69.4% +0.8%
=======================================
Files 124 135 +11
Lines 5366 6113 +747
=======================================
+ Hits 3680 4243 +563
- Misses 1582 1742 +160
- Partials 104 128 +24
|
@anuraaga @MrAlias @jmacd @Aneurysm9 Can you review this PR? I have closed the older one and opened a fresh PR with complete remote sampling support and tried to address most of the concerns/comments we have discussed. Feel free to take a look again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL at the suggestion.
While running the
|
That version should be retracted. Not sure why it is being used. You may be able to work around it temporarily by putting an |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
One final unresolved issue as far as I see: #1859 (comment) Otherwise this is looking good 👍 |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Also, not sure why linter check is failing. I'm able to run it in my local. Maybe re-running it would be helpful since it's some timeout issue. |
@MrAlias can you run tests again? looks like some flaky test failure. If you don't have further comments we would be okay to merge this? |
@MadVikingGod PTAL |
@MadVikingGod Can you take a look again to see if you have further comments on this PR or this is good to merge? |
I spoke with @MadVikingGod and he's good with this proceeding. He will ask for follow-up PRs if he has any concerns that need to be addressed. |
This PR introduces remote sampling support using AWS X-Ray. This implementation uses 2 X-Ray APIs as mentioned below.
Reference docs for some of the data structures used in implementation
https://docs.aws.amazon.com/xray/latest/devguide/xray-console-sampling.html#xray-console-config
https://docs.aws.amazon.com/xray/latest/api/API_GetSamplingRules.html
https://docs.aws.amazon.com/xray/latest/api/API_GetSamplingTargets.html