Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hosting+ProviderBuilderExtensions] Project nits and README updates for 1.4 #4223

Merged

Conversation

CodeBlanch
Copy link
Member

[These changes were originally part of #4071 but were removed to keep the diff minimal.]

Changes

  • Remove --prerelease for the projects about to go stable.
  • Clean up OpenTelemetry.Extensions.Hosting project file + turn on analysis.

@CodeBlanch CodeBlanch requested a review from a team as a code owner February 23, 2023 21:15
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #4223 (50e2033) into main (5b1889d) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
- Coverage   85.73%   85.65%   -0.09%     
==========================================
  Files         289      289              
  Lines       11374    11374              
==========================================
- Hits         9752     9742      -10     
- Misses       1622     1632      +10     
Impacted Files Coverage Δ
...s.Hosting/Implementation/TelemetryHostedService.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️

@CodeBlanch CodeBlanch merged commit 4f2bb57 into open-telemetry:main Feb 23, 2023
@CodeBlanch CodeBlanch deleted the releaseupdates-and-projectnits branch February 23, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants