Improve log message written by selfdiagnostics to file. #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
reviewed
Feb 23, 2023
utpilla
approved these changes
Feb 23, 2023
cijothomas
commented
Feb 23, 2023
| @@ -30,7 +30,7 @@ namespace OpenTelemetry.Internal | |||
| /// </summary> | |||
| internal class SelfDiagnosticsConfigRefresher : IDisposable | |||
| { | |||
| public static readonly byte[] MessageOnNewFile = Encoding.UTF8.GetBytes("Successfully opened file.\n"); | |||
| public static readonly byte[] MessageOnNewFile = Encoding.UTF8.GetBytes("If you are seeing this message, it means that the OpenTelemetry SDK has successfully created the log file used to write self-diagnostic logs. This file will be appended with logs as they appear. If you see this line, but nothing more, try changing the the LogLevel to show logs of lower severities.\n"); | |||
There was a problem hiding this comment.
If you are seeing this message, it means that the OpenTelemetry SDK has successfully created the log file
^ this was suggested by AI :)
xiang17
approved these changes
Feb 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4219 +/- ##
==========================================
- Coverage 85.57% 85.53% -0.05%
==========================================
Files 291 291
Lines 11398 11398
==========================================
- Hits 9754 9749 -5
- Misses 1644 1649 +5
|
vishweshbankwar
approved these changes
Feb 23, 2023
cijothomas
commented
Feb 23, 2023
Kielek
approved these changes
Feb 23, 2023
|
No product change, but a useful improvement to the opening message. Merging for 1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4218
Related : Azure/azure-sdk-for-net#34483