[Hosting] Remove obsolete methods ahead of 1.4.0 release #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
reviewed
Jan 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
==========================================
+ Coverage 85.55% 85.71% +0.15%
==========================================
Files 291 289 -2
Lines 11398 11374 -24
==========================================
- Hits 9752 9749 -3
+ Misses 1646 1625 -21
|
src/OpenTelemetry.Extensions.Hosting/OpenTelemetry.Extensions.Hosting.csproj
Outdated
Show resolved
Hide resolved
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
|
bump to remove stale |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
utpilla
approved these changes
Feb 23, 2023
cijothomas
reviewed
Feb 23, 2023
Kielek
reviewed
Feb 23, 2023
cijothomas
approved these changes
Feb 23, 2023
tomkerkhove
added a commit
to tomkerkhove/promitor
that referenced
this pull request
Feb 26, 2023
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove
added a commit
to tomkerkhove/promitor
that referenced
this pull request
Feb 27, 2023
* Bump OTEL & xUnit Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Fix breaking change open-telemetry/opentelemetry-dotnet#4071 Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Bump Arcus deps Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Fix code quality Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Fix failing test Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Bump System.Drawing.Common to fix vulnerability Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> --------- Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are reading this because you upgraded to 1.4.0 and your code no longer compiles, sorry! Much discussion went into this and we decided as a group it was the best path forward to not have obsolete code in our first shipped stable version. If you want to get up and running using the old API, you may use the RC version: 1.4.0-rc.4. That version contains everything in 1.4.0 minus this PR removing the old API.
Migration steps
Old style:
New style:
Other APIs...
Configureis available by casting the provider builder as eitherIDeferredTracerProviderBuilderorIDeferredMeterProviderBuilder.GetServicesis now available asConfigureServices.Changes
TODOs
CHANGELOG.mdupdated for non-trivial changes