Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RegistryOption in favor of RegisterOption #7012

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

bogdandrutu
Copy link
Member

This is consistent with other places where we call the options as the func that applies to.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

This is consisten with other places where we call the options as the func that applies to.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team as a code owner January 24, 2023 20:42
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 90.28% // Head: 90.28% // No change to project coverage 👍

Coverage data is based on head (800a02b) compared to base (fec9cd3).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7012   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         243      243           
  Lines       14584    14584           
=======================================
  Hits        13167    13167           
  Misses       1148     1148           
  Partials      269      269           
Impacted Files Coverage Δ
featuregate/registry.go 84.21% <71.42%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit b03b046 into open-telemetry:main Jan 25, 2023
@bogdandrutu bogdandrutu deleted the registeropts branch January 25, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants