Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a mechanism to allow adding new methods on the gRPC services #6966

Closed
bogdandrutu opened this issue Jan 18, 2023 · 1 comment · Fixed by #6967 or #7029
Closed

Provide a mechanism to allow adding new methods on the gRPC services #6966

bogdandrutu opened this issue Jan 18, 2023 · 1 comment · Fixed by #6967 or #7029
Labels
area:pdata pdata module related issues
Milestone
go.opentelemetry....

Comments

@bogdandrutu
Copy link
Member

Right now if the protobuf defines a new RPC method on the current services we will have a breaking change because of the Client/Server interfaces.
@bogdandrutu bogdandrutu added the area:pdata pdata module related issues label Jan 18, 2023
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Jan 18, 2023
@bogdandrutu
Enforce grpc server implementation to embed UnimplementedGRPCServer, …
43cd633 
…dissallow client implementation

Fixes open-telemetry#6966

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this issue Jan 18, 2023
Merged
bogdandrutu added a commit that referenced this issue Jan 19, 2023
@bogdandrutu
Start enforcing grpc server implementation to embed UnimplementedGRPC…
5358eb9 
…Server, dissallow client implementation (#6967)

* Enforce grpc server implementation to embed UnimplementedGRPCServer, dissallow client implementation

Fixes #6966

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update disallowimpl.yaml

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu reopened this Jan 19, 2023
@bogdandrutu
Copy link
Member Author

Reopen, the #6967 did not fix this since the unexported func on the server will be added in the next version to not break third-parties.

codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jan 23, 2023
@bogdandrutu
Start enforcing grpc server implementation to embed UnimplementedGRPC…
7ec477b 
…Server, dissallow client implementation (open-telemetry#6967)

* Enforce grpc server implementation to embed UnimplementedGRPCServer, dissallow client implementation

Fixes open-telemetry#6966

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update disallowimpl.yaml

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

* Update grpc.go

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Jan 26, 2023
@bogdandrutu
Add private method to GrpcServer interface, disallow direct implement…
ba3aae3 
…ation

Fixes open-telemetry#6966

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this issue Jan 26, 2023
Merged
bogdandrutu added a commit that referenced this issue Jan 27, 2023
@bogdandrutu
Add private method to GrpcServer interface, disallow direct implement…
e520829 
…ation (#7029)

Fixes #6966

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@mx-psi mx-psi mentioned this issue Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:pdata pdata module related issues
Projects
None yet
Milestone
go.opentelemetry.io/collector/pdata 1.0
1 participant
@bogdandrutu