Skip to content

[pdata] Make Slice.AsRaw() method exported #5311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented May 4, 2022

Resolves #5310

@dmitryax dmitryax requested review from a team and Aneurysm9 May 4, 2022 05:20
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #5311 (0fe06cb) into main (df00d05) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5311      +/-   ##
==========================================
+ Coverage   90.54%   90.58%   +0.03%     
==========================================
  Files         190      190              
  Lines       11109    11109              
==========================================
+ Hits        10059    10063       +4     
+ Misses        827      824       -3     
+ Partials      223      222       -1     
Impacted Files Coverage Δ
pdata/internal/common.go 95.38% <100.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df00d05...0fe06cb. Read the comment docs.

@dmitryax dmitryax force-pushed the expose-slice-asraw branch from 53854f2 to 0fe06cb Compare May 5, 2022 06:02
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the need for this method? Just curious.

@dmitryax
Copy link
Member Author

dmitryax commented May 6, 2022

It's needed in contrib in one place https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/9c214be44477ef84daa0770a3f0464fc25eae7cf/exporter/lokiexporter/encode_json.go#L98

Also it seems inconsistent that Map has it while Slice doesn't

@bogdandrutu bogdandrutu merged commit 79911de into open-telemetry:main May 10, 2022
@dmitryax dmitryax deleted the expose-slice-asraw branch May 10, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pdata] Inconsistently exported AsRaw methods
2 participants