Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stringer for service.State #4938

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

bogdandrutu
Copy link
Member

Nicer log messages if state is logged.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team as a code owner March 1, 2022 23:57
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #4938 (7c2deec) into main (73a30a6) will increase coverage by 0.17%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4938      +/-   ##
==========================================
+ Coverage   90.85%   91.02%   +0.17%     
==========================================
  Files         178      178              
  Lines       10594    10611      +17     
==========================================
+ Hits         9625     9659      +34     
+ Misses        753      735      -18     
- Partials      216      217       +1     
Impacted Files Coverage Δ
service/collector.go 76.68% <90.90%> (+1.51%) ⬆️
service/config_provider.go 94.17% <0.00%> (-0.22%) ⬇️
config/configtelemetry/configtelemetry.go 90.32% <0.00%> (ø)
service/telemetry.go 76.25% <0.00%> (+14.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a30a6...7c2deec. Read the comment docs.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 2, 2022
service/collector.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 0c85cfb into open-telemetry:main Mar 2, 2022
@bogdandrutu bogdandrutu deleted the statestring branch March 2, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants