Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve otel collector/jaeger pipeline compatibility #491

Closed
joe-elliott opened this issue Jan 6, 2020 · 1 comment · Fixed by #513
Closed

Improve otel collector/jaeger pipeline compatibility #491

joe-elliott opened this issue Jan 6, 2020 · 1 comment · Fixed by #513

Comments

@joe-elliott
Copy link
Contributor

joe-elliott commented Jan 6, 2020

Using jaeger-debug-id has an issue that reveals an incompatibility between otel-collector and the jaeger pipeline. jaeger-debug-id generates spans with invalid refs which are dropped by the otel-collector but are passed and stored by the Jaeger pipeline/backend.

To increase compatibility with the jaeger processing pipeline we'd like to pass/store spans that have these invalid refs.

@joe-elliott joe-elliott changed the title Improve otel collector/jaeger-debug-id compatibility Improve otel collector/jaeger pipeline compatibility Jan 7, 2020
@joe-elliott
Copy link
Contributor Author

The following was removed from the original issue in favor of #502.

Add logging to increase visibility on this issue. Currently these dropped lines are metric'ed but nothing is logged:

protoBatch, err := jaegertranslator.OCProtoToJaegerProto(td)
if err != nil {
return len(td.Spans), consumererror.Permanent(err)
}

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
* Fix github-release

* Stage artifact uniquely for signing concurrency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant