Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated funcs in pdata #4809

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Remove deprecated funcs in pdata #4809

merged 1 commit into from
Feb 25, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team as a code owner February 5, 2022 01:38
@project-bot project-bot bot added this to In progress in Collector Feb 5, 2022
@codecov
Copy link

codecov bot commented Feb 5, 2022 •
edited

Codecov Report

Merging #4809 (bf7c50b) into main (d21d20b) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head bf7c50b differs from pull request most recent head c161af2. Consider uploading reports for the commit c161af2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4809      +/-   ##
==========================================
+ Coverage   90.82%   90.86%   +0.03%     
==========================================
  Files         181      181              
  Lines       10632    10628       -4     
==========================================
  Hits         9657     9657              
+ Misses        759      755       -4     
  Partials      216      216
Impacted Files Coverage Δ
model/pdata/logs.go 95.83% <ø> (+13.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21d20b...c161af2. Read the comment docs.

codeboten
codeboten approved these changes Feb 7, 2022
View reviewed changes
model/pdata/logs.go Show resolved Hide resolved
Collector automation moved this from In progress to Reviewer approved Feb 7, 2022
jpkrohling
jpkrohling previously requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I'm getting conflicts that are not apparent via the web UI when rebasing this to remove the changelog entry. Perhaps someone could do it instead?

CHANGELOG.md Outdated Show resolved Hide resolved
Collector automation moved this from Reviewer approved to Review in progress Feb 17, 2022
@bogdandrutu bogdandrutu force-pushed the rmdeprpdata branch 2 times, most recently from 490d5fa to a290e31 Compare February 18, 2022 19:55
@bogdandrutu
Copy link
Member Author

@jpkrohling PTAL :)

@bogdandrutu
Copy link
Member Author

@jpkrohling ping :)

@jpkrohling jpkrohling dismissed their stale review February 23, 2022 07:56

dismissing, as it seems the original concern (changelog) has been addressed

Collector automation moved this from Review in progress to Reviewer approved Feb 23, 2022
@bogdandrutu
Remove deprecated funcs in pdata
c161af2 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 7bdb684 into open-telemetry:main Feb 25, 2022
@bogdandrutu bogdandrutu deleted the rmdeprpdata branch February 25, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling jpkrohling left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Collector
  
Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bogdandrutu @jpkrohling @codeboten @dmitryax