Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileDataProvider to the testbed #2444

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Feb 8, 2021

FileDataProvider in an implementation of the DataProvider for use in end-to-end tests.
The data to send is loaded from a file. The file should contain one JSON-encoded
Export*ServiceRequest Protobuf message. The file can be recorded using the "file"
exporter.

FileDataProvider is useful for implementing end-to-end tests that use realistic data.
As an example I also added TestMetricsFromFile which uses testdata/k8s-metrics.json
real world data that I recorded using k8scluster receiver running on my local
Kubernetes cluster.

@tigrannajaryan tigrannajaryan requested a review from a team as a code owner February 8, 2021 23:39
@project-bot project-bot bot added this to In progress in Collector Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@73b8408). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2444   +/-   ##
=======================================
  Coverage        ?   91.84%           
=======================================
  Files           ?      264           
  Lines           ?    15064           
  Branches        ?        0           
=======================================
  Hits            ?    13835           
  Misses          ?      853           
  Partials        ?      376           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b8408...d7c7b53. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Feb 9, 2021
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/filedataprovider branch 2 times, most recently from a0983df to e3956da Compare February 9, 2021 14:05
FileDataProvider in an implementation of the DataProvider for use in end-to-end tests.
The data to send is loaded from a file. The file should contain one JSON-encoded
Export*ServiceRequest Protobuf message. The file can be recorded using the "file"
exporter.

FileDataProvider is useful for implementing end-to-end tests that use realistic data.
As an example I also added TestMetricsFromFile which uses testdata/k8s-metrics.json
real world data that I recorded using k8scluster receiver running on my local
Kubernetes cluster.
@tigrannajaryan tigrannajaryan merged commit 90ccbfa into open-telemetry:main Feb 9, 2021
Collector automation moved this from Reviewer approved to Done Feb 9, 2021
@tigrannajaryan tigrannajaryan deleted the feature/tigran/filedataprovider branch February 9, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants