You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Compiling from the source package fails with the error:
/bin/bash: line 1: /internal/tools/tools.go: No such file or directory
This seems to be because SRC_ROOT requires a git based checkout as per:
Makefile.Common
14:# SRC_ROOT is the top of the source tree.
15:SRC_ROOT := $(shell git rev-parse --show-toplevel)
17:TOOLS_MOD_DIR := $(SRC_ROOT)/internal/tools
18:TOOLS_BIN_DIR := $(SRC_ROOT)/.tools
When git rev-parse --show-toplevel fails to run SRC_ROOT="" and the pathing gets screwed up.
What did you expect to see?
Checking out the git repo, switching to tag v0.99.0 and running make works just fine. I expected it to work from package source as well.
The text was updated successfully, but these errors were encountered:
@thehaven Note that make will eventually (after running tests and linters) build a test version of the Collector.
If you want to build a (usable on prod) Collector from source I would recommend using the Collector builder. By default it will generate a binary, but you can also use --skip-compilation to generate the code, inspect it and then build it yourself
Describe the bug
Compiling from the source package fails with the error:
This seems to be because SRC_ROOT requires a git based checkout as per:
When git rev-parse --show-toplevel fails to run SRC_ROOT="" and the pathing gets screwed up.
Steps to reproduce
Download and run make:
What did you expect to see?
Checking out the git repo, switching to tag v0.99.0 and running make works just fine. I expected it to work from package source as well.
The text was updated successfully, but these errors were encountered: