Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package testing to this repository #439

Open
mx-psi opened this issue Dec 14, 2023 · 6 comments
Open

Move package testing to this repository #439

mx-psi opened this issue Dec 14, 2023 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 14, 2023

We have some package tests on opentelemetry-collector-contrib that should instead live here, since this is where we produce the packages and we do not have a mechanism to keep track of changes to the package scripts or systemd service definitions.

See open-telemetry/opentelemetry-collector-contrib/pull/29286 for context

@Enzujp
Copy link
Contributor

Enzujp commented Mar 13, 2024

hey @mx-psi , has this been resolved yet, and would you like for me to give it a go with your guidance of course ?

@mx-psi
Copy link
Member Author

mx-psi commented Mar 13, 2024

@Enzujp this has not been resolved. It's probably a bit harder than #498, but I am happy to help if you have specific questions :)

@Enzujp
Copy link
Contributor

Enzujp commented Mar 26, 2024

Hii @mx-psi , @ so I've gone through conversations from open-telemetry/opentelemetry-collector-contrib#29286 and, through the buildscripts dir . Moving package testing to this repository would require making edits to almost all individual files within buildscripts since most of its configurations are set to the opentelemetry-collector-contrib repo.
Am I right ?

@mx-psi
Copy link
Member Author

mx-psi commented Mar 27, 2024

@Enzujp yes, you are right! And in general: this may not be a trivial task, these tests have not been modified for a long time and a long has changed since

@Enzujp
Copy link
Contributor

Enzujp commented Mar 27, 2024

I'm trying out solutions to automate the release notes, should be done soon; and then I'd come back and we can map out doing this together?. :)

@mx-psi
Copy link
Member Author

mx-psi commented Mar 27, 2024

@Enzujp Sure! I am out until next week, but feel free to Slack me on the CNCF Slack (you can find my name on my profile :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants