@BinaryFissionGames Could we put this in pkg and make it just a module instead of an extension? Usually extensions are supposed to export a component that gets put into the service, as where modules in the pkg directory are only intended to be used as libraries.

@BinaryFissionGames Could we put this in pkg and make it just a module instead of an extension? Usually extensions are supposed to export a component that gets put into the service, as where modules in the pkg directory are only intended to be used as libraries.

I'm certainly open to it. The reason I chose not to is based on the storage module:
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/storage

It also mirrors in the non-contrib repo how the storage package is also nested under extension:
https://github.com/open-telemetry/opentelemetry-collector/tree/main/extension/experimental/storage

And also the auth module, which contains the authcation extension interfaces:
https://github.com/open-telemetry/opentelemetry-collector/tree/main/extension/auth

So it seemed like this was the current pattern.

Still happy to change it if you think I should.

Encoding seems like another example of a module that is not component that's nested under extension:
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/encoding

Thanks for the examples. I haven't dug into those extensions too much, I didn't know they exported interfaces as well. I'd say you have it right putting it under extension, let's leave it as-is.

As a side note, thanks for being mindful of the deprecation process; I agree that we can just move the interfaces as part of a breaking change like you've done here.

You'll need to add this module to cmd/checkapi/allowlist.txt since we're exporting more than just a NewFactory function.