[pkg/translator/prometheusremotewrite] Introduce API based around hash based metrics identifiers #32666
Labels
enhancement
New feature or request
needs triage
New item requiring triage
pkg/translator/prometheusremotewrite
Comments
aknuds1
added
enhancement
aknuds1
changed the title
|
Pinging code owners:
%s See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This was referenced Apr 24, 2024
MovieStoreGuy
pushed a commit
that referenced
this issue
Apr 29, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> I noticed the output of a recent comment made by the `github-actions` bot had an extra `%s` in its output when pinging code owners on new issues. This is unnecessary. Example links: #32666 (comment) #32723 (comment)
aknuds1
changed the title
|
Please note that I dropped the proposal of generating the |
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this issue
May 8, 2024
…elemetry#32724) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> I noticed the output of a recent comment made by the `github-actions` bot had an extra `%s` in its output when pinging code owners on new issues. This is unnecessary. Example links: open-telemetry#32666 (comment) open-telemetry#32723 (comment)
jlg-io
pushed a commit
to jlg-io/opentelemetry-collector-contrib
that referenced
this issue
May 14, 2024
…elemetry#32724) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> I noticed the output of a recent comment made by the `github-actions` bot had an extra `%s` in its output when pinging code owners on new issues. This is unnecessary. Example links: open-telemetry#32666 (comment) open-telemetry#32723 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
pkg/translator/prometheusremotewrite
Is your feature request related to a problem? Please describe.
There is a remaining performance related problem with the
translator/prometheusremotewritemodule: The new API that I introduced based around hash based metric identifiers is hidden behind theFromMetricsshim, and as a result the full performance benefits are not reaped.Describe the solution you'd like
The solution we (Grafana Mimir and Prometheus maintainers) would like is to expose the
prometheusConvertertype withintranslator/prometheusremotewrite, which is currently hidden behind the wrappingFromMetricsfunction. Let it expose two methods:Benchmarks
Benchmarking stats PrometheusConverter.FromMetrics vs. FromMetrics wrapper function
Describe alternatives you've considered
Additional context
In conjunction with my previous PR, converting from string based metrics identifiers to hash based ones, @Aneurysm9 requested that I open an issue with a proposal for exposing the new converter type. In an OTel call, @Aneurysm9 also suggested that the proposal include a framework for converting directly to other formats than Prometheus.
Regarding the latter point, I've arrived at an approach where I transform the
prometheusremotewritesources to the Mimir equivalent mainly through a tool called gopatch. This means there's not much need for facilitation in opentelemetry-collector-contrib sources.The text was updated successfully, but these errors were encountered: