Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIG Proposal for Sustainability Metrics #2018

Merged
merged 5 commits into from May 13, 2024

Conversation

Spazzy757
Copy link
Contributor

@Spazzy757 Spazzy757 commented Mar 25, 2024

This proposes a project and working group for establishing Semantic Conventions for sustainability.

We aim to unify and and establish standards for monitoring sustainability metrics

Resolves #2020

projects/env-semconv.md Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
@almereyda
Copy link

Resolves #2018

This line in the description, which will be in the merge commit, references itself, which is a certain kind of fun in itself, but would probably do good to point at #2020 for people accessing this conversation from the future commit.

@Spazzy757 Spazzy757 force-pushed the main branch 3 times, most recently from 251427b to f83092a Compare April 5, 2024 09:15
@Spazzy757
Copy link
Contributor Author

There is a poll for a meeting time in the CNCF slack channel for this project

cc @gabibeyer @bertysentry @mkorbi @rossf7 @marceloamaral

projects/env-semconv.md Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
@danielgblanco danielgblanco added the Project Proposal Submitting a filled out project template label Apr 8, 2024
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Spazzy757, this looks good.

projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
projects/env-semconv.md Outdated Show resolved Hide resolved
@Spazzy757
Copy link
Contributor Author

Hi @pyohannes, is there anything more that this need?

@jpkrohling
Copy link
Member

As discussed during today's GC triage, @danielgblanco will be a GC sponsor, and @pyohannes is the community sponsor delegated by me. I tried to make the required changes to this PR, but it looks like I can't. Here's the proposed diff:

diff --git a/projects/env-semconv.md b/projects/env-semconv.md
index 7e230e2..58aa81a 100644
--- a/projects/env-semconv.md
+++ b/projects/env-semconv.md
@@ -24,8 +24,8 @@ We want to have a unified conventions in order to better facilitate measuring su
 - @spazzy757
 
 **Sponsoring Members**
-- @jpkrohling 
-- @pyohannes 
+- @danielgblanco
+- @pyohannes (delegated by @jpkrohling, as per [project proposal guidelines](https://github.com/open-telemetry/community/blob/main/project-management.md#project-proposal))
 
 **Engineers**
 - @gabibeyer

@jpkrohling
Copy link
Member

There's something else missing here as well: an entry to the sigs.yaml.

https://github.com/open-telemetry/community/blob/main/sigs.yml

@danielgblanco should also be the sponsor there.

@trask
Copy link
Member

trask commented Apr 29, 2024

@pyohannes is the community sponsor delegated by me

semconv maintainers are always allowed to sponsor semconv related SIGs (but looks like we haven't documented it)

@jpkrohling
Copy link
Member

semconv maintainers are always allowed to sponsor semconv related SIGs (but looks like we haven't documented it)

I knew I was missing something, and I thought we talked about this somewhere, but couldn't find evidence to back it up :-) Thank you for confirming!

@danielgblanco
Copy link
Contributor

@Spazzy757 could you change @jpkrohling for @danielgblanco in the doc? I think this is good to go after that change as we've got the necessary approvals! 🚀

@danielgblanco danielgblanco changed the title Working Group Proposal for Sustainability Metrics SIG Proposal for Sustainability Metrics May 6, 2024
@Spazzy757 Spazzy757 force-pushed the main branch 5 times, most recently from 03c1c38 to 6acf9eb Compare May 6, 2024 09:34
Signed-off-by: Spazzy <brendankamp757@gmail.com>
@Spazzy757
Copy link
Contributor Author

Updated!

@pyohannes
Copy link
Contributor

Looks good, @danielgblanco could you please do a final review?

Copy link
Contributor

@danielgblanco danielgblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Looking forward to this SIG starting! 💚

@greenhsu123
Copy link

Hi all, a great proposal. I would like to be added to the list of contributors. Thanks!!

@danielgblanco
Copy link
Contributor

As we have a majority of GC votes and the project meets all requirements, I'm merging this. Looking forward to this SIG starting! 🎉 @greenhsu123 can be added later in a different PR (this is standard practice in projects)

@Spazzy757 as lead of this project, can you open an issue in the community repo to create meeting calendar, set up necessary GitHub groups, etc? We'll need to add those to the public calendar and list the SIG along with the rest in the official docs.

@danielgblanco danielgblanco merged commit 3185df3 into open-telemetry:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project Proposal Submitting a filled out project template
Projects
Status: Potential Projects
Development

Successfully merging this pull request may close these issues.

[WIP] Working Group: Add sustainability Metrics to Semantic Conventions