New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allow_custom_values
flag on enums or change the default value to true
#294
Comments
3 tasks
3 tasks
3 tasks
Hello @lmolkova , can i work on this issue? |
Hi @AkhigbeEromo , thanks for the interest in build-tools! We're considering moving the functionality over to https://github.com/open-telemetry/weaver. You're very welcome to contribute there. We'll be finalizing the plan and will have a better idea of specific tasks it involves soon. |
3 tasks
3 tasks
An update on this issue:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're reserving the right to add values to enums in the future in the spec
https://github.com/open-telemetry/opentelemetry-specification/blob/4f71c1642e541220e293bacf8c0d58f1fbcd3111/specification/versioning-and-stability.md?plain=1#L228-L231
But by default
allow_custom_values
is set tofalse
resulting in "MUST be one of the following:" in the markdown and some confusion.I suggest removing the flag completely, but given it's a breaking change, we can also consider changing it to
true
by default.The text was updated successfully, but these errors were encountered: