Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] audit repository tooling #212

Open
6 of 8 tasks
Tracked by #12
sakshi-1505 opened this issue Oct 8, 2023 · 6 comments
Open
6 of 8 tasks
Tracked by #12

[security] audit repository tooling #212

sakshi-1505 opened this issue Oct 8, 2023 · 6 comments

Comments

@sakshi-1505
Copy link

sakshi-1505 commented Oct 8, 2023

The security SIG is looking to ensure that security tooling is setup consistently across the organization. As a result, we're asking maintainers to ensure the following tools are enabled in each repository:

  • CodeQL enabled via GitHub Actions
  • Static code analysis tool (the collector uses govulncheck [https://pkg.go.dev/golang.org/x/vuln] on every build)
  • Repository security settings
    • Security Policy ✅
    • Security advisories ✅
    • Private vulnerability reporting ✅
    • Dependabot alerts ✅
    • Code scanning alerts ✅

Parent issue: open-telemetry/sig-security#12

@sakshi-1505
Copy link
Author

@arminru Please confirm if vulnerability reporting, dependabot alerts are configured for the repo as I don't have enough access to see those. I do see we have majority of the repo in Python with a lil of Go but I don't see us using any staticcode checker for Python, do you folks have any suggestion in mind for the same? I know we can use Mypy or Pylint.

Meanwhile I will open a PR for CodeQL scanning with schedule same as other repos.

@Oberon00
Copy link
Member

@open-telemetry/technical-committee I think you are still the only ones that have access to view the mentioned settings. Please check.

@sakshi-1505 For Python we already use both mypy and pylint, and addtionally flake8 (and black + isort but these are probably less security relevant). https://github.com/open-telemetry/build-tools/blob/main/.github/workflows/semconvgen.yml Most of these could use an upgrade (we have dependabot PRs but with new linter errors that would need to be fixed), and there is also https://github.com/astral-sh/ruff which seems to be the new cool tool that would replace all 3 of pylint, flake8 and isort while being faster. So if somebody has time, there is always potential for improvement, but I think we have the basics covered (and note that the semantic convention generator is development tooling and not distributed to or used by end users)

@sakshi-1505
Copy link
Author

@Oberon00 please check #214

@arminru
Copy link
Member

arminru commented Oct 16, 2023

@Oberon00 I looked into the repo settings mentioned in the issue description, adjusted them where needed, and ticked the boxes.

@sakshi-1505
Copy link
Author

Thanks a lot @arminru , can you please also review #214?

@sakshi-1505
Copy link
Author

cc: @codeboten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants