Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced logo #80

Closed

Conversation

Sandeep18JS
Copy link

@Sandeep18JS Sandeep18JS commented May 2, 2024

Description

This PR adds the Logo on Documentation.

What type of PR is this? (check all applicable)

  • ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 📝 Documentation Update

Related Tickets & Documents

Fixes #79

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

@Sandeep18JS Sandeep18JS requested a review from a team May 2, 2024 12:14
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sandeep18JS,

Thank you for working on this! ✨

For now, I'll assign you to the issue. But next time, please read our contributing guidelines. You need to be assigned to an issue before you can work on the changes. 🙂

Please read the issue carefully. We want you to replace the link in the src and not adding the logo to the asset.

Can you please:

  • remove the logo from the asset
  • change the link to the logo
  • remove the width
  • fix the alt with "OpenSauced"

You can refer to this line of code on our app repo.

https://github.com/open-sauced/app/blob/1da1c519222093b8fd9f9abbddffda4c3094fce2/README.md?plain=1#L3

Please also fix the keyword in Related Tickets to "Fixes", not "Fixes/Relates".

Let me know if you have any question. Thanks!

@adiati98
Copy link
Member

adiati98 commented May 6, 2024

@Sandeep18JS I'm not sure why I can't assign or tag you in the issue's comment.

@Sandeep18JS
Copy link
Author

@adiati98 I made the requested changes...

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Sandeep18JS! 🙌

If you haven't, you can join our community Discord. 😊

git merge GIF

@adiati98 adiati98 requested a review from BekahHW May 7, 2024 22:38
@Sandeep18JS Sandeep18JS closed this by deleting the head repository May 8, 2024
@adiati98
Copy link
Member

Hey @Sandeep18JS,

Is there any reason why you close this PR after it's approved?

This PR hasn't been merged yet. It still need one more approval from our team before it can be merged.

If you don't want to proceed, I will unassign you from the issue and give it to someone else. Just let me know. Thanks.

@Sandeep18JS
Copy link
Author

@Sandeep18JS sorry my mistake , yea you can unassign me for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chores: Replace the logo in this repo's README
2 participants