Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A pre built binary for darwin/amd64 wasn't released at v0.64.0 #6720

Closed
suzuki-shunsuke opened this issue Apr 25, 2024 · 3 comments · Fixed by #6721
Closed

A pre built binary for darwin/amd64 wasn't released at v0.64.0 #6720

suzuki-shunsuke opened this issue Apr 25, 2024 · 3 comments · Fixed by #6721
Labels
bug

Comments

@suzuki-shunsuke
Copy link
Contributor

https://github.com/open-policy-agent/opa/releases/tag/v0.64.0

image 
$ gh release view -R open-policy-agent/opa --json assets v0.64.0 -q '.assets[].name'
opa_darwin_arm64
opa_darwin_arm64.sha256
opa_darwin_arm64_static
opa_darwin_arm64_static.sha256
opa_linux_amd64
opa_linux_amd64.sha256
opa_linux_amd64_static
opa_linux_amd64_static.sha256
opa_linux_arm64_static
opa_linux_arm64_static.sha256
opa_windows_amd64.exe
opa_windows_amd64.exe.sha256

The asset opa_darwin_amd64 wasn't released.
@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Apr 25, 2024 •
edited

I think this is because the architecture of GitHub Actions Runner macos-latest was changed from amd64 to arm64.
I'll send a pull request.

opa/.github/workflows/post-merge.yaml

Line 111 in 75cc90a

runs-on: macos-latest

opa/.github/workflows/post-merge.yaml

Line 127 in 75cc90a

run: make ci-build-darwin ci-build-darwin-arm64-static

opa/Makefile

Line 19 in 75cc90a

GOARCH := $(shell go env GOARCH)

opa/Makefile

Lines 286 to 291 in 75cc90a

.PHONY: ci-build-darwin
ci-build-darwin: ensure-release-dir
@$(MAKE) build GOOS=darwin
chmod +x opa_darwin_$(GOARCH)
mv opa_darwin_$(GOARCH) $(RELEASE_DIR)/
cd $(RELEASE_DIR)/ && shasum -a 256 opa_darwin_$(GOARCH) > opa_darwin_$(GOARCH).sha256

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

@ashutosh-narkar
Copy link
Member

Good catch. We should probably pin the macos version to avoid this.

@suzuki-shunsuke suzuki-shunsuke mentioned this issue Apr 25, 2024
Merged
@suzuki-shunsuke
Copy link
Contributor Author

@suzuki-shunsuke suzuki-shunsuke mentioned this issue Apr 25, 2024
Closed
ashutosh-narkar pushed a commit that referenced this issue Apr 26, 2024
@suzuki-shunsuke
ci: pin GitHub Actions macos runner version and build for darwin/amd64
bf28d8e 
Fixes: #6720

Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
ashutosh-narkar pushed a commit to ashutosh-narkar/opa that referenced this issue Apr 26, 2024
@suzuki-shunsuke @ashutosh-narkar
ci: pin GitHub Actions macos runner version and build for darwin/amd64
bc7afc7 
Fixes: open-policy-agent#6720

Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
(cherry picked from commit bf28d8e)
ashutosh-narkar pushed a commit that referenced this issue Apr 26, 2024
@suzuki-shunsuke @ashutosh-narkar
ci: pin GitHub Actions macos runner version and build for darwin/amd64
faf6382 
Fixes: #6720

Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
(cherry picked from commit bf28d8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: pin GitHub Actions macos runner version and build for darwin/amd64 suzuki-shunsuke/opa
2 participants
@ashutosh-narkar @suzuki-shunsuke