tester/runner: Fix panic'ing case in utility function. #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipaconrad
force-pushed
the
issue-5496
branch
from
35fd8f2
to
5fb7830
Compare
ashutosh-narkar
previously approved these changes
Dec 21, 2022
philipaconrad
force-pushed
the
issue-5496
branch
from
5fb7830
to
68afa8d
Compare
|
Thanks for the quick approval, @ashutosh-narkar. I'm rebasing the PR to catch up with |
tsandall
previously approved these changes
Dec 21, 2022
There was a problem hiding this comment.
I'm guessing we're not testing this code path since the old version would panic. It's probably worth adding a rule that triggered the panic here: https://github.com/open-policy-agent/opa/blob/main/tester/runner_test.go#L59.
|
That should be easy enough to add. One second... |
This commit fixes a panic from a utility function in the `opa test` codepath. After the ref-heads change in open-policy-agent#4660, this particular function could be fed a ref that it didn't know how to work with, such as the innocuous line `a[0] := 1`, and it would then panic. This was fixed by returning a dummy value instead of panic'ing. Fixes: open-policy-agent#5496 Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
philipaconrad
dismissed stale reviews from tsandall and ashutosh-narkar
via
a6c37ad
philipaconrad
force-pushed
the
issue-5496
branch
from
68afa8d
to
a6c37ad
Compare
philipaconrad
added a commit
to philipaconrad/opa
that referenced
this pull request
Dec 21, 2022
…gent#5497) This commit fixes a panic from a utility function in the `opa test` codepath. After the ref-heads change in open-policy-agent#4660, this particular function could be fed a ref that it didn't know how to work with, such as from the innocuous line `a[0] := 1`, and it would then panic. This was fixed by returning a dummy value instead of panic'ing. Fixes: open-policy-agent#5496 Signed-off-by: Philip Conrad <philipaconrad@gmail.com> (cherry picked from commit a08934d)
philipaconrad
added a commit
that referenced
this pull request
Dec 21, 2022
This commit fixes a panic from a utility function in the `opa test` codepath. After the ref-heads change in #4660, this particular function could be fed a ref that it didn't know how to work with, such as from the innocuous line `a[0] := 1`, and it would then panic. This was fixed by returning a dummy value instead of panic'ing. Fixes: #5496 Signed-off-by: Philip Conrad <philipaconrad@gmail.com> (cherry picked from commit a08934d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a panic from a utility function in the
opa testcodepath. After the ref-heads change in #4660, this particular function could be fed a ref that it didn't know how to work with, such as the innocuous linea[0] := 1, and it would then panic.This was fixed by returning a dummy value instead of panic'ing.
Fixes: #5496