ast/parser: fix else handling with ref heads #5425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
previously approved these changes
Nov 29, 2022
|
Unexpected test fallout... I'll have a look in a bit. |
srenatus
force-pushed
the
sr/ast/parser-else-handling
branch
from
859bee8
to
5395c31
Compare
srenatus
commented
Nov 29, 2022
| @@ -644,9 +644,12 @@ func (p *Parser) parseRules() []*Rule { | |||
| } | |||
|
|
|||
| if p.s.tok == tokens.Else { | |||
|
|
|||
| if r := rule.Head.Ref(); len(r) > 1 && !r[len(r)-1].Value.IsGround() { | |||
There was a problem hiding this comment.
For a non-ref-head rule, like
a := 1 if truethe ref is Ref{VarTerm("a")}, and that would be a false-positive for the check if done without len(r)>1.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/ast/parser-else-handling
branch
from
5395c31
to
a4679ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a case that slipped through the parser, but failed at a later stage. It's now caught early.