Exit with failure on empty signing key #5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Joffre <mariusjoffre@gmail.com>
|
😳 Just realised that the tests fail in some real way: https://github.com/open-policy-agent/opa/actions/runs/3316251882/jobs/5510243839#step:6:20 -- Could you please have a look? 👀 |
Signed-off-by: Mathis Joffre <mariusjoffre@gmail.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Normally everything works well now. I missed a case. |
srenatus
approved these changes
Nov 2, 2022
srenatus
added a commit
to srenatus/opa
that referenced
this pull request
Nov 2, 2022
Since `alg` has a default setting, we've gotten that error too often. Follow-up to open-policy-agent#5297 and open-policy-agent#4972. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
added a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathis Joffre mariusjoffre@gmail.com
Closes #4972