topdown/tokens: protect against nistec panics #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Golang 1.19, the code used in crypto/elliptic has switched to nistec, and this introduced new panics where there hadn't been any before. To play along with this, we're adding defer/recover constructs. It's only about bad inputs; none of those offending points could ever be valid. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
ashutosh-narkar
approved these changes
Oct 6, 2022
byronic
pushed a commit
to byronic/opa
that referenced
this pull request
Oct 17, 2022
With Golang 1.19, the code used in crypto/elliptic has switched to nistec, and this introduced new panics where there hadn't been any before. To play along with this, we're adding defer/recover constructs. It's only about bad inputs; none of those offending points could ever be valid. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Byron Lagrone <byron.lagrone@seqster.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Golang 1.19, the code used in crypto/elliptic has switched to nistec, and this introduced new panics where there hadn't been any before.
To play along with this, we're adding defer/recover constructs. It's only about bad inputs; none of those offending points could ever be valid.