Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Future Keywords document #5192

Merged
merged 1 commit into from Sep 30, 2022

Conversation

nasa9084
Copy link
Contributor

@nasa9084 nasa9084 commented Sep 28, 2022

we need to use future.keywords.* to import a future keyword as written in every keyword section, right?

@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit dcca283611acd9fb0a732a9c81c760c4b746c174
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/6333e19c52124600083dbb58
😎 Deploy Preview https://deploy-preview-5192--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nasa9084 nasa9084 changed the title Fix typo in Future Keywords Fix typo in Future Keywords document Sep 28, 2022
@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit f914cfeb956268583db58c6d29c91c05a1624fec
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/63360a85c0a98600084f8799
😎 Deploy Preview https://deploy-preview-5192--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nasa9084 nasa9084 marked this pull request as ready for review September 28, 2022 06:23
srenatus
srenatus previously approved these changes Sep 28, 2022
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

philipaconrad
philipaconrad previously approved these changes Sep 29, 2022
@philipaconrad
Copy link
Contributor

Apparently the Github UI's "rebase this PR" button broke DCO? Odd. 🙁

@philipaconrad
Copy link
Contributor

Aha! DCO is confused about the commit signoff from @nasa9084. (Emails do not match.)

Signed-off-by: nasa9084 <nasa.9084.bassclarinet@gmail.com>
@nasa9084
Copy link
Contributor Author

I rebased onto main, tests are running for now but it seems it passed DCO check

@anderseknert anderseknert merged commit 15b9a88 into open-policy-agent:main Sep 30, 2022
@nasa9084 nasa9084 deleted the patch-1 branch September 30, 2022 10:41
byronic pushed a commit to byronic/opa that referenced this pull request Oct 17, 2022
Signed-off-by: nasa9084 <nasa.9084.bassclarinet@gmail.com>
Signed-off-by: Byron Lagrone <byron.lagrone@seqster.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants