build: run 'make generate' in release container #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the docker image so that we get one that has all of these commands available: make, git, go, python2 and perl. We can now run `make generate` in the steps used to generate the release patch, so the release patch contains the builtin_metadata.json changes. Before, we had been running `make generate` in the working directory, and copied the file into the container's workdir; but that left the working directory modified, and hindered patch application before cleaning up. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
commented
Jul 25, 2022
| ifeq ($(GITHUB_TOKEN),) | ||
| @echo "\033[0;31mGITHUB_TOKEN environment variable missing.\033[33m Provide a GitHub Personal Access Token (PAT) with the 'read:org' scope.\033[0m" | ||
| endif | ||
| @$(DOCKER) run $(DOCKER_FLAGS) \ | ||
| -e GITHUB_TOKEN=$(GITHUB_TOKEN) \ | ||
| -e LAST_VERSION=$(LAST_VERSION) \ | ||
| -v $(PWD):/_src \ | ||
| python:2.7 \ | ||
| cmd.cat/make/git/go/python2/perl \ |
There was a problem hiding this comment.
Alright I'll admit that I'm not proud of this. But I really kind of dislike having to manage building and tagging and pushing images for these maintenance jobs.
Ideally, we'd be using apko here, I think; but it's macos story is a bit annoying (lima); which we wouldn't have to worry about much if kontain.me just worked on it, but it kind of doesn't...
philipaconrad
approved these changes
Jul 25, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the docker image so that we get one that has all of these
commands available: make, git, go, python2 and perl.
We can now run
make generatein the steps used to generate the release patch,so the release patch contains the builtin_metadata.json changes.
Before, we had been running
make generatein the working directory, andcopied the file into the container's workdir; but that left the working
directory modified, and hindered patch application before cleaning up.