ast/compiler: allow retaining parsed modules #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/ast/expose-parsed-modules
branch
2 times, most recently
from
5cba436
to
943cb87
Compare
srenatus
commented
Jul 21, 2022
srenatus
commented
Jul 21, 2022
srenatus
force-pushed
the
sr/ast/expose-parsed-modules
branch
from
943cb87
to
8b8b632
Compare
srenatus
commented
Jul 22, 2022
srenatus
force-pushed
the
sr/ast/expose-parsed-modules
branch
2 times, most recently
from
e6edc4d
to
d44c601
Compare
srenatus
force-pushed
the
sr/ast/expose-parsed-modules
branch
from
d44c601
to
27d189c
Compare
|
I wonder if in the future we may want to have a special callout comment format for functions that return uncopied/mutate-able results. I guess that could become worthwhile if we add several more systems like this one. 🤔 |
philipaconrad
previously approved these changes
Jul 25, 2022
The included change resetting `c.sorted` in `(*Compiler).Compile(...)` was necessary to test the repeated compilation without a panic. Fixes open-policy-agent#4910. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/ast/expose-parsed-modules
branch
from
27d189c
to
c0fdef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included change resetting
c.sortedin(*Compiler).Compile(...)wasnecessary to test the repeated compilation without a panic.
Fixes #4910.