storage/disk: make symlinks work with relative paths #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/storage/disk/fix-relative-links-and-restarts
branch
from
cb50d20
to
bb0a5ba
Compare
srenatus
force-pushed
the
sr/storage/disk/fix-relative-links-and-restarts
branch
from
bb0a5ba
to
d355455
Compare
srenatus
commented
Jul 11, 2022
|
|
||
| txn := storage.NewTransactionOrDie(ctx, s, storage.WriteParams) | ||
| func TestTruncateRelativeStoragePath(t *testing.T) { | ||
| dir := "foobar" |
There was a problem hiding this comment.
This is a bit messy, but I think it's better to test it this way -- potentially polluting some work dir -- than not at all.
srenatus
commented
Jul 11, 2022
| t.Fatalf("Expected get policy to return %v but got: %v (err: %v)", expectedBytes, bs, err) | ||
| } | ||
|
|
||
| // Close and re-open store |
There was a problem hiding this comment.
This is the new thing -- it would catch the previous failure, which would yield to not being able to deref the symlink foobar/foobar/backupXXXX.
So for now, we'll properly create the symlinks without the wrong indirection. Fixes open-policy-agent#4869. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/storage/disk/fix-relative-links-and-restarts
branch
from
d355455
to
0dee8cf
Compare
ashutosh-narkar
approved these changes
Jul 11, 2022
srenatus
added a commit
to srenatus/opa
that referenced
this pull request
Jul 13, 2022
…nt#4870) So for now, we'll properly create the symlinks without the wrong indirection. Fixes open-policy-agent#4869. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
added a commit
that referenced
this pull request
Jul 13, 2022
So for now, we'll properly create the symlinks without the wrong indirection. Fixes #4869. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So for now, we'll properly create the symlinks without the wrong indirection.
Fixes #4869.
I'm still looking into remediation logic: if the symlink is wrong, fix it automatically.Update: I think we should keep this as-is. The first is simple enough to guide the few people who could have run into it at this point to the proper steps.