Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v0.42.0 #4834

Merged
merged 1 commit into from Jul 4, 2022
Merged

Conversation

srenatus
Copy link
Contributor

@srenatus srenatus commented Jul 1, 2022

🎉

Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some suggestions, but except for the typo nothing that needs to be changed.


To use the new keywords, use `import future.keywords.contains` and `import future.keywords.if`; or
import all of them at once via `import future.keywords`. When these future imports are present, the
pretty printer (`opa fmt`) will introduce `contains` and `if` where applicable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real nice touch!

CHANGELOG.md Outdated
import all of them at once via `import future.keywords`. When these future imports are present, the
pretty printer (`opa fmt`) will introduce `contains` and `if` where applicable.

`if` is allowed in all places to separe the rule head from the body, like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate?


To use the new keywords, use `import future.keywords.contains` and `import future.keywords.if`; or
import all of them at once via `import future.keywords`. When these future imports are present, the
pretty printer (`opa fmt`) will introduce `contains` and `if` where applicable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

CHANGELOG.md Outdated

`if` is allowed in all places to separe the rule head from the body, like
```rego
foo[x] = y if { x := "a", y := "b" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we try and keep up with the “real world” policy example, ie avoid using “foo” and so on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good point

CHANGELOG.md Outdated

- ast/parser: Remove early MHS return in infix parsing. (#4773) ([#4672](https://github.com/open-policy-agent/opa/issues/4672)) authored by @philipaconrad
- ast: Disallow shadowing of called functions in comprehension heads (#4701) ([#4762](https://github.com/open-policy-agent/opa/issues/4762))
- built-ins: add object.subset() builtin ([#4358](https://github.com/open-policy-agent/opa/issues/4358)) authored by @charlesdaniels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could highlight this better.

@srenatus srenatus force-pushed the sr/release-0.42.0 branch 2 times, most recently from 4acf15c to 62c2323 Compare July 1, 2022 12:32
CHANGELOG.md Outdated
- Runtime Errors: Fix type error message in `count`, `object.filter`, and `object.remove` built-in functions ([#4767](https://github.com/open-policy-agent/opa/issues/4767))
- Parser: Remove early MHS return in infix parsing, fixing confusing error messages ([#4672](https://github.com/open-policy-agent/opa/issues/4672)) authored by @philipaconrad
- AST: Disallow shadowing of called functions in comprehension heads ([#4762](https://github.com/open-policy-agent/opa/issues/4762))
- planner: shadow rule funcs if mocking functions (#4745) ([#4746](https://github.com/open-policy-agent/opa/issues/4746))
Copy link
Contributor Author

@srenatus srenatus Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't edited the bullets of this section from hereon down yet 👇

CHANGELOG.md Outdated

### Miscellaneous

- ci: bump golangci-lint to v1.46.2, fix some issues (#4809) ([#4765](https://github.com/open-policy-agent/opa/issues/4765)) reported by @philipaconrad
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block also isn't edited yet

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
@srenatus srenatus merged commit 9b5fb9b into open-policy-agent:main Jul 4, 2022
@srenatus srenatus deleted the sr/release-0.42.0 branch July 4, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants