Ignore keys of unknown alg when verifying JWTs with JWKS #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
jwt-verification-enhancements
branch
4 times, most recently
from
e4e7377
to
9daa6b3
Compare
|
The ticket also has a request for improved documentation. At the very least, we should document this new behavior. |
Additionally, improve the JWT verification process when a JWKS is provided: * If `kid` is present in JWT header, and exists in JWKS — verify using that key only. * If `kid` not present in JWT header, try verification only using keys matching the `alg` provided in the JWT header (mandatory claim). Fixes open-policy-agent#4699 Signed-off-by: Anders Eknert <anders@eknert.com>
anderseknert
force-pushed
the
jwt-verification-enhancements
branch
from
9daa6b3
to
5a23fb0
Compare
If I understand the conversation between @lenalebt and @srenatus correctly, the suggested update to the docs would be to change the example not to use the raw body (i.e. string) representation of the JWKS, but to rather hack around the issue (fixed by this PR) by unmarshalling the JWKS, filter out the non-parseable key(s), and then marshall it back into a new JWKS to use for validation. The documented solution is AFAICS the correct one. |
johanfylling
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, improve the JWT verification process when a JWKS
is provided:
kidis present in JWT header, and exists in JWKS — verify usingthat key only.
kidnot present in JWT header, try verification only using keysmatching the
algprovided in the JWT header (mandatory claim).Fixes #4699
Signed-off-by: Anders Eknert anders@eknert.com