Add metadata option to .manifest #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundle/bundle.go
Outdated
| @@ -180,7 +180,7 @@ func (m Manifest) Copy() Manifest { | |||
|
|
|||
| func (m Manifest) String() string { | |||
| m.Init() | |||
| return fmt.Sprintf("<revision: %q, roots: %v, wasm: %+v>", m.Revision, *m.Roots, m.WasmResolvers) | |||
| return fmt.Sprintf("<revision: %q, roots: %v, wasm: %+v, metadata: %x>", m.Revision, *m.Roots, m.WasmResolvers, m.Metadata) | |||
There was a problem hiding this comment.
Change %x to %+v
marensws
force-pushed
the
add-metadata-option-to-.manifest
branch
5 times, most recently
from
1c7891b
to
fd17716
Compare
marensws
force-pushed
the
add-metadata-option-to-.manifest
branch
3 times, most recently
from
0fd3ba2
to
6d969b9
Compare
fixes: open-policy-agent#4289 Signed-off-by: marensws <msws@live.no>
marensws
force-pushed
the
add-metadata-option-to-.manifest
branch
from
f589f50
to
6c24ab7
Compare
srenatus
approved these changes
Jan 31, 2022
| @@ -180,6 +181,12 @@ func (c *Compiler) WithCapabilities(capabilities *ast.Capabilities) *Compiler { | |||
| return c | |||
| } | |||
|
|
|||
| //WithMetadata sets the additional data to be included in .manifest | |||
There was a problem hiding this comment.
[nit]
Suggested change
| //WithMetadata sets the additional data to be included in .manifest | |
| // WithMetadata sets the additional data to be included in .manifest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4289