Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.send: Add metrics to evaluate cache performance #4023

Closed
ashutosh-narkar opened this issue Nov 16, 2021 · 0 comments · Fixed by #4087
Closed

http.send: Add metrics to evaluate cache performance #4023

ashutosh-narkar opened this issue Nov 16, 2021 · 0 comments · Fixed by #4087
Labels
builtins
Projects
Open Policy Agent

Comments

@ashutosh-narkar
Copy link
Member

http.send supports an inter-query cache to cache responses across queries. Currently we do not have any metrics that would allow users to know how the cache is performing. Adding a counter to measure cache hit rate would help users understand the cache performance. We can add other counters if needed as well.
@ashutosh-narkar ashutosh-narkar added this to TODO (Things That Should Be Done) in Open Policy Agent via automation Nov 16, 2021
@mirayadav mirayadav mentioned this issue Dec 2, 2021
Merged
mirayadav pushed a commit to mirayadav/opa that referenced this issue Dec 3, 2021
@mirayadav
http.send: Add metric for counting inter-query cache hits
66587da 
An inter-query cache is used to cache responses for http.send. This change allows users to gain insight into how the cache is performing by tracking the number of cache hits.
Fixes: open-policy-agent#4023

Signed-off-by: Mira Yadav <mira.yadav620@gmail.com>
Open Policy Agent automation moved this from Backlog to Done Dec 3, 2021
srenatus pushed a commit that referenced this issue Dec 3, 2021
@mirayadav
http.send: Add metric for counting inter-query cache hits (#4087)
1c51402 
An inter-query cache is used to cache responses for http.send. This change allows users to gain insight into how the cache is performing by tracking the number of cache hits.
Fixes: #4023

Signed-off-by: Mira Yadav <mira.yadav620@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builtins
Projects
Open Policy Agent
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http.send: Add metric for counting inter-query cache hits mirayadav/opa
2 participants
@tsandall @ashutosh-narkar