Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nodejs express documentation #2976

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Adding nodejs express documentation #2976

merged 1 commit into from
Dec 8, 2020

Conversation

amitkanfer
Copy link
Contributor

No description provided.

@amitkanfer amitkanfer marked this pull request as ready for review December 4, 2020 13:15
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about possible mistake. Except for that this looks like a great addition!

@@ -439,7 +450,6 @@ integrations:
- javaspringsecurity
code:
- https://github.com/open-policy-agent/contrib/tree/master/spring_authz
- https://github.com/Bisnode/opa-spring-security
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was done by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooopss.. No idea how this happened!

Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now - just squash the commits and this should be good to go 👍

anderseknert
anderseknert previously approved these changes Dec 6, 2020
srenatus
srenatus previously approved these changes Dec 7, 2020
@amitkanfer
Copy link
Contributor Author

@anderseknert can we merge?

@anderseknert
Copy link
Member

@amitkanfer yes, but you'll need to re-squash your commits so that there's only one of them left to merge. Once done I'll merge right away.

@anderseknert
Copy link
Member

Also note that there was just another merge to the integrations.md just now so you'll want to rebase on top of master first.

@srenatus
Copy link
Contributor

srenatus commented Dec 8, 2020

🔍 There's a typo in your commit message: ndoejs -> nodejs 😅

Signed-off-by: amitkanfer <amit@build.security>
@anderseknert anderseknert merged commit be8234f into open-policy-agent:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants