-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding nodejs express documentation #2976
Adding nodejs express documentation #2976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about possible mistake. Except for that this looks like a great addition!
docs/website/data/integrations.yaml
Outdated
@@ -439,7 +450,6 @@ integrations: | |||
- javaspringsecurity | |||
code: | |||
- https://github.com/open-policy-agent/contrib/tree/master/spring_authz | |||
- https://github.com/Bisnode/opa-spring-security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this was done by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooopss.. No idea how this happened!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now - just squash the commits and this should be good to go 👍
@anderseknert can we merge? |
@amitkanfer yes, but you'll need to re-squash your commits so that there's only one of them left to merge. Once done I'll merge right away. |
Also note that there was just another merge to the integrations.md just now so you'll want to rebase on top of master first. |
🔍 There's a typo in your commit message: |
Signed-off-by: amitkanfer <amit@build.security>
d2dcb0d
No description provided.