panic: local variable rewriting corrupts objects #2661
Comments
tsandall
added this to TODO (Things That Should Be Done)
in Open Policy Agent
via automation
tsandall
moved this from TODO (Things That Should Be Done)
to In Progress
in Open Policy Agent
tsandall
added a commit
to tsandall/opa
that referenced
this issue
Aug 27, 2020
The local variable rewriting stage was mutating object keys while iterating over the object itself. This caused the object to become corrupted. This commit fixes the issue by switching the stage to use the transformer interface which can safely mutate objects. The transformer is more expensive because it preemptively copies terms. If this is an issue, we could special case the transformer usage to when an object would be mutated. Fixes open-policy-agent#2661 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The nightly fuzzing job found another crasher. Simplified version:
In this case, the rewriting of 'x' corrupts the object value in the head.
The text was updated successfully, but these errors were encountered: