New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAM module pam_sm_acct_mgmt call always returns success #223

Open

tetlowgm opened this issue Jun 9, 2023 · 0 comments

tetlowgm commented Jun 9, 2023

See

contrib/pam_opa/pam/pam.c

Lines 65 to 68 in b63c03a

    
           // Do exactly the same thing for both auth and account invocations. 
        
           pam_sm_authenticate(pamh, flags, argc, argv); 
        
           return PAM_SUCCESS;

If this module is implemented with an account module instead of an auth module, it always returns success, regardless of what OPA says it should.

Instead, it should return the value on line 66, not discard it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment