Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions CI. #85

Merged
merged 3 commits into from Nov 5, 2019
Merged

Switch to GitHub Actions CI. #85

merged 3 commits into from Nov 5, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Oct 25, 2019

Issues:

  1. We need Actions enabled for the repo
  2. chokidar-cli requires the $SHELL env var which is not set on Actions CI. We could set it ourselves but I think this could be more clever. Not sure how tests pass right now on Travis; do they set the $SHELL variable?
  3. Windows tests fail either with git bash or native cmd
  4. tests don't seem to exit when a failure happens, i.e. there's an unhandled Promise rejection somewhere in tests

Preview of the failed test: https://github.com/XhmikosR/chokidar-cli/runs/274861409

Fixes #83

@XhmikosR
Copy link
Contributor Author

Maybe someone should look into using cross-spawn and getting rid of that whole custom code?

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 26, 2019

Alright, I managed to get it to pass on all 3 OS https://github.com/XhmikosR/chokidar-cli/runs/275972034

Still, I'm not sure of my changes. For one tests leave processes open. Secondly, I needed to set DEBUG_TESTS = true which means something else is going on with the pipe option.

I'll leave this to someone else after we have Actions for cross-platform testing.

@XhmikosR XhmikosR marked this pull request as ready for review November 5, 2019 05:41
@paulmillr paulmillr merged commit 99e4b47 into open-cli-tools:master Nov 5, 2019
@XhmikosR XhmikosR deleted the gh-actions branch November 5, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to GitHub Actions CI
2 participants