feat: implement draft for a Nest.js SDK #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyert
approved these changes
Dec 12, 2023
|
Just also added the |
chenhunghan
reviewed
Dec 13, 2023
chenhunghan
reviewed
Dec 13, 2023
chenhunghan
reviewed
Dec 13, 2023
toddbaert
reviewed
Dec 13, 2023
toddbaert
reviewed
Dec 13, 2023
Yep that works for me! You'll have to manually add an entry in https://github.com/open-feature/js-sdk/blob/main/.release-please-manifest.json though. |
beeme1mr
reviewed
Dec 13, 2023
Great, changed that. |
toddbaert
reviewed
Dec 13, 2023
toddbaert
approved these changes
Dec 13, 2023
toddbaert
reviewed
Dec 13, 2023
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
…context Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Co-authored-by: Luiz Guilherme Ribeiro <ltrindaderibeiro@gmail.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
feat/nestjs-sdk-draft
branch
from
df5d164
to
df70937
Compare
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
|
I would merge this now, so we can work together on different questions. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.2-experimental](nestjs-sdk-v0.0.1-experimental...nestjs-sdk-v0.0.2-experimental) (2023-12-13) ### ✨ New Features * implement draft for a Nest.js SDK ([#718](#718)) ([ef874e0](ef874e0)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @openfeature/core bumped from * to 0.0.21 * @openfeature/server-sdk bumped from * to 1.8.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
added a commit
that referenced
this pull request
Jan 11, 2024
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> This is a first draft of a Nest.js SDK. Currently it only handles injecting clients and feature flags. I also added a context factory for the FeatureFlag decorators to be able to use request information for the execution context. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes #705 ### Notes <!-- any additional notes for this PR --> @toddbaert maybe we can do it as we did with the React SDK, merge this fast and release as experimental to let people experiment and try out? ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> We will have to see if we want to stick with the injected feature flags being wrapped in an observable. To me this feels the most idiomatic for Nest.js. ### How to test Tests for the current functionality are included. --------- Signed-off-by: Lukas Reining <lukas.reining@codecentric.de> Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Co-authored-by: Luiz Guilherme Ribeiro <ltrindaderibeiro@gmail.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
added a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.2-experimental](nestjs-sdk-v0.0.1-experimental...nestjs-sdk-v0.0.2-experimental) (2023-12-13) ### ✨ New Features * implement draft for a Nest.js SDK ([#718](#718)) ([ef874e0](ef874e0)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @openfeature/core bumped from * to 0.0.21 * @openfeature/server-sdk bumped from * to 1.8.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This is a first draft of a Nest.js SDK.
Currently it only handles injecting clients and feature flags.
I also added a context factory for the FeatureFlag decorators to be able to use request information for the execution context.
Related Issues
Fixes #705
Notes
@toddbaert maybe we can do it as we did with the React SDK, merge this fast and release as experimental to let people experiment and try out?
Follow-up Tasks
We will have to see if we want to stick with the injected feature flags being wrapped in an observable.
To me this feels the most idiomatic for Nest.js.
How to test
Tests for the current functionality are included.