Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Update Dockerfiles #67

Closed
yolile opened this issue Oct 28, 2021 · 0 comments · Fixed by #68
Closed

docker: Update Dockerfiles #67

yolile opened this issue Oct 28, 2021 · 0 comments · Fixed by #68

Comments

@yolile
Copy link
Member

yolile commented Oct 28, 2021

I tried to build the frontend Dockerfile locally but I got the error described here: nodejs/docker-node#384

The solution is what is described now in the base image documentation: https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#node-gyp-alpine

Then, also in the frontend Dockerfile, the node:14-alpine base image should be used, as the dependency node-saas is used in its version 4.14 which is compatible only with node 14

We should also update the frontend and backend Dockerfiles to be run as a non-root user as open-contracting/deploy#320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant