Replace `date-fns` by `date-and-time-formatter` #443

paescuj · 2023-09-23T21:56:27Z

Fixes #436

Backwards-compatible because date-fns follows Unicode LDML too (well, more or less https://blog.date-fns.org/v2-unicode-tokens/)

coveralls · 2023-09-23T21:59:39Z

coverage: 99.197%. remained the same when pulling 28f51ae on replace-date-fns-by-date-and-time-formatter into a61ef39 on main.

gustavohenke · 2023-10-02T08:24:22Z

bin/concurrently.ts

@@ -151,7 +151,7 @@ const args = yargs(argsBeforeSep)
        },
        'timestamp-format': {
            alias: 't',
-            describe: 'Specify the timestamp in moment/date-fns format.',
+            describe: 'Specify the timestamp in Unicode LDML format.',


While this is technically correct, I wonder how many people won't know how to find usage examples for LDML.

For instance, for me, Google returns one result for "unicode ldml" in the first page that is more "straight to the point" IMO:
https://stackoverflow.com/q/39904392/2083599

Good point! Should we explicitly link https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns in this description?

Probably, but i'm worried it might not be formatted well by yargs.

Something like #445 (or better) is looking promising now...

paescuj · 2023-12-17T15:49:18Z

src/index.ts

@@ -43,7 +43,7 @@ export type ConcurrentlyOptions = BaseConcurrentlyOptions & {

    /**
     * Date format used when logging date/time.
-     * @see https://date-fns.org/v2.0.1/docs/format
+     * @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table


Suggested change

* @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table

* @see https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns

paescuj · 2023-12-17T15:49:32Z

src/defaults.ts

@@ -61,7 +61,7 @@ export const success = 'all' as SuccessCondition;

 /**
 * Date format used when logging date/time.
- * @see https://date-fns.org/v2.0.1/docs/format
+ * @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table


Suggested change

* @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table

* @see https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns

paescuj · 2023-12-17T15:52:09Z

README.md

@@ -346,7 +348,7 @@ For more details, visit https://github.com/open-cli-tools/concurrently
    Anything else means all processes should exit successfully.
  - `restartTries`: how many attempts to restart a process that dies will be made. Default: `0`.
  - `restartDelay`: how many milliseconds to wait between process restarts. Default: `0`.
-  - `timestampFormat`: a [date-fns format](https://date-fns.org/v2.0.1/docs/format)
+  - `timestampFormat`: a [Unicode LDML format](https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table)


Suggested change

- `timestampFormat`: a [Unicode LDML format](https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table)

- `timestampFormat`: a [Unicode LDML date format](https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns)

liquidg3 · 2024-04-23T17:33:28Z

date-fns pushed a breaking change and we're having issues in our projects.

It would be helpful to either upgrade to date-fns to the latest or to replace it entirely (based on this PR). We've set resolutions in our package.json (we use yarn) for now, but I always forget to remove them and it's gonna bite future us right before something important, you know, like when most these things tend to rear their heads.

Thanks everyone!!

paescuj changed the title ~~Replace date-fns by date-and-time-formatter~~ Replace date-fns by date-and-time-formatter Sep 23, 2023

Replace date-fns by date-and-time-formatter

28f51ae

paescuj force-pushed the replace-date-fns-by-date-and-time-formatter branch from 7fd13e6 to 28f51ae Compare September 23, 2023 22:06

gustavohenke reviewed Oct 2, 2023

View reviewed changes

paescuj added this to the v9 milestone Oct 19, 2023

paescuj commented Dec 17, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `date-fns` by `date-and-time-formatter` #443

Replace `date-fns` by `date-and-time-formatter` #443

paescuj commented Sep 23, 2023 •

edited

coveralls commented Sep 23, 2023 •

edited

gustavohenke Oct 2, 2023

paescuj Dec 17, 2023

gustavohenke Dec 23, 2023

paescuj Dec 17, 2023

paescuj Dec 17, 2023

paescuj Dec 17, 2023

liquidg3 commented Apr 23, 2024

	* @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table
	* @see https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns

	- `timestampFormat`: a [Unicode LDML format](https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table)
	- `timestampFormat`: a [Unicode LDML date format](https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns)

Replace date-fns by date-and-time-formatter #443

Are you sure you want to change the base?

Replace date-fns by date-and-time-formatter #443

Conversation

paescuj commented Sep 23, 2023 • edited

coveralls commented Sep 23, 2023 • edited

gustavohenke Oct 2, 2023

Choose a reason for hiding this comment

paescuj Dec 17, 2023

Choose a reason for hiding this comment

gustavohenke Dec 23, 2023

Choose a reason for hiding this comment

paescuj Dec 17, 2023

Choose a reason for hiding this comment

paescuj Dec 17, 2023

Choose a reason for hiding this comment

paescuj Dec 17, 2023

Choose a reason for hiding this comment

liquidg3 commented Apr 23, 2024

Replace `date-fns` by `date-and-time-formatter` #443

Replace `date-fns` by `date-and-time-formatter` #443

paescuj commented Sep 23, 2023 •

edited

coveralls commented Sep 23, 2023 •

edited