Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passthrough-arguments leads to trailing slashes in argument key on Windows #398

Open
asimen1 opened this issue Dec 27, 2022 · 1 comment

Comments

@asimen1
Copy link

asimen1 commented Dec 27, 2022

Description:
Using -P, --passthrough-arguments leads to trailing slashes in argument key on Windows (and stackblitz.com).

On local Mac doesn't reproduce.
If adding only the key without value (e.g. yarn test --key) doesn't reproduce as well.

Expected Behavior:
Argument key should not have a trailing slash when specifying argument value.

Environment:
concurrently v7.6.0
OS: Windows 10
Node v16.14.2

Reproduction:
stackblitz
in terminal type: npm run test -- --key=value or yarn test --key=value

See Images attached:
image
image

@gustavohenke
Copy link
Member

gustavohenke commented Dec 27, 2022

@paescuj one you might like 😃
I don't remember why exactly we needed shell-quote. It's definitely causing this (it's right here). Was it to support expanding e.g. {@} when already wrapped in quotes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants