Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command async tests #369

Merged
merged 1 commit into from Oct 2, 2022
Merged

Fix command async tests #369

merged 1 commit into from Oct 2, 2022

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented Sep 22, 2022 •
edited

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b165f4 on paescuj:fix-async-tests into dc20842 on open-cli-tools:main.

@paescuj paescuj mentioned this pull request Sep 22, 2022
Merged
gustavohenke
gustavohenke approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels slightly over engineered, but perhaps there's not many better ways

@paescuj
Copy link
Collaborator Author

paescuj commented Oct 2, 2022 •
edited

I get you... Happy if someone finds a better way!

@paescuj paescuj merged commit c095c08 into open-cli-tools:main Oct 2, 2022
@paescuj paescuj deleted the fix-async-tests branch October 2, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paescuj @coveralls @gustavohenke