Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tests #335

Merged
merged 3 commits into from Jul 4, 2022
Merged

Enhance tests #335

merged 3 commits into from Jul 4, 2022

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented Jun 27, 2022

  • Enhance the test for the logger option in concurrently as suggested by @gustavohenke in Code Style & Performance Optimizations聽#334 (comment)
    • While working on this test, I realized that we should extend the corresponding if statement with a check for outputStream, since it doesn't make sense to pass the log to the OutputWriter if there is no output stream.
  • Increase coverage on Node.js 12 (we get a score of 馃挴 with this) by ensuring the logger is always defined in the LogTimings class.
    For this I marked the printExitInfoTimingTable method as private... @gustavohenke Do you think this would be a breaking change?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 100.0% when pulling d7fcb11 on paescuj:enhance-tests into cc05702 on open-cli-tools:main.

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this would be a breaking change?

It's not really documented how it's meant to be used, so probably not?

I never really thought of exposing the flow controllers for their internals, but to allow one to customise which ones they want when manually building their concurrently instance.

@paescuj
Copy link
Collaborator Author

paescuj commented Jul 4, 2022

Do you think this would be a breaking change?

It's not really documented how it's meant to be used, so probably not?

I never really thought of exposing the flow controllers for their internals, but to allow one to customise which ones they want when manually building their concurrently instance.

That's how I see it too! Additionally, LogTimings is the only controller with another method besides handle. So IMO it makes sense to mark it private.

@paescuj paescuj merged commit 02b9082 into open-cli-tools:main Jul 4, 2022
@paescuj paescuj deleted the enhance-tests branch July 4, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants