Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style & Performance Optimizations #334

Merged
merged 22 commits into from Jun 24, 2022
Merged

Code Style & Performance Optimizations #334

merged 22 commits into from Jun 24, 2022

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented Jun 23, 2022

  • Prefer object spread & slice for better readability and performance
  • Disallow console.log statements via ESLint
  • Speed up GitHub workflow by doing "Lint & Format" checks only once per run and using better NPM cache setup
  • Speed up tests by using swc as transformer and for CLI tests
  • Add some missing test cases
  • Move Jest config to own file for better readability and validation
  • Optimize NPM script for prettier

@paescuj paescuj changed the title Code & Performance Optimizations Code Style & Performance Optimizations Jun 23, 2022
@coveralls
Copy link

coveralls commented Jun 23, 2022

Coverage Status

Coverage increased (+1.5%) to 99.472% when pulling 988c59f on paescuj:optimizations into 0980e5b on open-cli-tools:main.

@paescuj paescuj merged commit 06c83bc into open-cli-tools:main Jun 24, 2022
@paescuj paescuj deleted the optimizations branch June 24, 2022 11:18
src/command-parser/expand-arguments.ts Show resolved Hide resolved
src/concurrently.spec.ts Show resolved Hide resolved
bin/concurrently.spec.ts Show resolved Hide resolved
@paescuj paescuj mentioned this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants